Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make slide routes async, prevent crash on syntax errors #1357

Merged
merged 25 commits into from
Mar 3, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Feb 29, 2024

This PR contains:

Internal changes

  • Slide components are now async. And a loading animation is added after 100ms. Not very sure about this animation.
  • rawRoutes is renamed to slides, with reduced data.

@KermanX KermanX changed the title refactor: hmr fix: hmr Feb 29, 2024
@KermanX KermanX changed the title fix: hmr fix: slide routes Mar 2, 2024
@KermanX KermanX marked this pull request as ready for review March 2, 2024 14:23
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid PR as always, thanks!

@antfu antfu changed the title fix: slide routes fix: make slide routes async, prevent crash on syntax errors Mar 3, 2024
@antfu antfu merged commit bf87a69 into slidevjs:main Mar 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants