New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: draggable element #1402
Merged
Merged
feat: draggable element #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Mar 23, 2024
Is there any possibility we can use |
Yeah I was thinking about that, having a directive would be nice but I guess it will not be easy to do. We could leave it for the future |
antfu
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
<v-drag>
component:Then you can double-click the element in the slide, and then drag it to resize and move it. The
pos
prop will be auto-updated. Clicking outside the currently active fixed element will stop the dragging.Initially, you don't need to specify the
pos
prop, which will be auto-generated on the first drag.The format of
pos
isleft,top,width,height,rotate
.rotate
is omitted when it is0
.Press shift when resizing, the aspect ratio will be fixed.
You can also use arrow keys to move the element.
About HMR
In the following situations, the new position will be written back to the Markdown:
debounce(500)
However, there are still some restrictions:
Todos
<v-drag ...
in code block or comment. Currently, the writing back is based on the index of regex match.width
andheight
to beauto
.Notes
It would be better if we could use
v-fixed
as a directive, but I don't know how to do this.The behavior is mostly learned from Figma.