fix: remove empty export from transpiled ts file #1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing an import, the typescript compiler automatically decides "well this file must be a module".
slidev/packages/client/setup/code-runners.ts
Lines 158 to 163 in f04f2eb
import type {UnionToIntersection} from 'type-fest'
->export {};
However, since the compiled TS code getts embedded in a function, the empty export code doesn't fit into the body of a function.
slidev/packages/client/setup/code-runners.ts
Lines 73 to 76 in f04f2eb
Instead you get
ERROR: SyntaxError: Unexpected token 'export'
See https://stackblitz.com/edit/github-qj6z8s?file=slides.md
This PR sanitizes the JS before running by removing the empty export {}; produced by typescript.