Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional wake lock #1676

Merged
merged 3 commits into from
Jun 17, 2024
Merged

feat: optional wake lock #1676

merged 3 commits into from
Jun 17, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Jun 15, 2024

resolve #1552.

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 05394af
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/666e7b1e92bcff000871459b
😎 Deploy Preview https://deploy-preview-1676--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Jun 15, 2024

Awesome idea!

@antfu
Copy link
Member

antfu commented Jun 15, 2024

I think we could have it enabled by default (when the app is on the front). With a client button and context menu to toggle it. And the frontmatter option can disable this feature completely.

In client, the state can be Keep awake when slides in front Always keep awake Do not keep awake

@KermanX
Copy link
Member Author

KermanX commented Jun 16, 2024

I think we could have it enabled by default (when the app is on the front). With a client button and context menu to toggle it. And the frontmatter option can disable this feature completely.

In client, the state can be Keep awake when slides in front Always keep awake Do not keep awake

Added this option to the settings popover:

If the tab is not on the front, the wake lock will become effectless automatically by the browser.

@antfu antfu merged commit 8dce420 into slidevjs:main Jun 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep slide show tab alive—Safari locks it in incognito mode
2 participants