Haml 2 slim now works with ruby 1.9 syntax #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#23 did not notice this pull request. Total should of checked first lol |
Found it was a lot of work to change HAML to Slim if you have ruby 1.9 syntax. This can make things difficult to use this tool. Was replacing the style: attributes string incorrectly Style attribute would replace some times when it matches. Example below style: "margin: 10px;" => style=":margin => 10px;" Make sure that there is no space between the key and colon
added 4 commits
January 19, 2016 11:11
There where are a few cases where trailing white space would make it impossible to replace the data template
| @@ -22,4 +22,6 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "ruby_parser" | |||
| s.add_development_dependency 'rake' | |||
| s.add_development_dependency "slim", [">= 1.0.0"] | |||
| s.add_development_dependency 'minitest', '~> 5.8.3' | |||
| s.add_development_dependency 'pry' | |||
There was a problem hiding this comment.
you added this as a development dependency, but it appears required at runtime as well.
There was a problem hiding this comment.
removed the require pryfrom the converter.rb must of left it in after testing out the tool.
|
This gem still has a bug with things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it was a lot of work to change HAML to Slim if you have ruby 1.9
syntax. This can make things difficult to use this tool.