Bump Ruby versions for Travis #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
januszm
commented
Feb 3, 2017
januszm
commented
- latest 2.2 and 2.3
- 2.4.0
|
cc @swrobel it might require more work, there are some issues with Rails 4.x |
januszm
force-pushed
the
bump_ruby_versions
branch
from
e5a4759
to
0d2cbfa
Compare
swrobel
reviewed
Feb 3, 2017
| @@ -3,8 +3,9 @@ before_install: | |||
| - gem install bundler | |||
| rvm: | |||
| - ruby-head | |||
| - 2.3.3 | |||
| - 2.2.6 | |||
| - 2.4.0 | |||
There was a problem hiding this comment.
Why not 2.4 and let it automatically use the latest 2.4.x instead of locking to 2.4.0?
There was a problem hiding this comment.
because RVM won't work with it and Travis uses RVM
|
what can you do :) |
|
They'll fix it around 2.4.1 I guess and we'll be able to switch to '2.4' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.