LF/CRLF is not coverted to NUL in Multiboot module string

[jiaqingz-intel]

When loading Multiboot container, the LF/CRLF is not coverted to NUL in Multiboot module string when booting

The command I used to build container is below, it was copied from https://github.com/intel/meta-acrn/blob/master/docs/slimbootloader.md

sudo python3 GenContainer.py create -cl CMDL:cmdline.txt ACRN:acrn.32.out CMD0:sos-cmdline.txt IMG0:vmlinuz -k ./SblKeys/OS1_TestKey_Priv_RSA3072.pem -a RSA3072_PKCS1_SHA2_384 -t MULTIBOOT -o container.bin

Both ACRN and SlimBootloader prints the string of the multiboot module as below, followed by chararcters not belonging to string

Linux_bzImage
  LZDMh, 

Multiboot Spec (https://www.gnu.org/software/grub/manual/multiboot/multiboot.html#Boot-information-format) says both cmdline and module string are null-terminated string. Is not converting to the NUL termintaor expected?

The cmdline is parsed at

slimbootloader/PayloadPkg/OsLoader/OsLoader.c

Lines 444 to 467 in a34e54e

	//
	// Allocate a cmd line buffer and init it with config file or default value
	// Later, maybe there is new command line parameters appended
	//
	NewCmdBuffer = (UINT8 *) AllocatePages (EFI_SIZE_TO_PAGES (CMDLINE_LENGTH_MAX));
	if (NewCmdBuffer == NULL) {
	return EFI_OUT_OF_RESOURCES;
	}
	CmdFile = &LoadedImage->Image.Common.CmdFile;
	Size = 0;
	if (CmdFile->Addr != NULL && CmdFile->Size != 0) {
	Size = (UINT32)GetFromConfigFile (NewCmdBuffer, CMDLINE_LENGTH_MAX, (UINT8 *)CmdFile->Addr, CmdFile->Size);
	}
	if (Size == 0) {
	Size = (UINT32)AsciiStrSize (DEFAULT_COMMAND_LINE);
	CopyMem (NewCmdBuffer, DEFAULT_COMMAND_LINE, Size);
	}
	// Free Allocated Memory earlier first
	FreeImageData (CmdFile);
	// Assign new one
	CmdFile->Addr = NewCmdBuffer;
	CmdFile->Size = Size;
	CmdFile->AllocType = ImageAllocateTypePage;

[stanleyintel]

Hi Jiaqing,

Thanks for reporting the issue. A PR is created to fix it.

[stanleyintel]

Hi,

As described in the PR, the patch fixes the issue that a mod string shall be a zero-terminated ASCII string (required by multboot spec), but it does not convert newlines to NULL (not required by multiboot spec).