Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APL] INT34D2 entry is missing in DSDT #390

Closed
umaplehurst opened this issue Oct 16, 2019 · 4 comments · Fixed by #402
Closed

[APL] INT34D2 entry is missing in DSDT #390

umaplehurst opened this issue Oct 16, 2019 · 4 comments · Fixed by #402

Comments

@umaplehurst
Copy link
Contributor

A device entry for INT34D2 is missing under Platform/ApollolakeBoardPkg/AcpiTables/Dsdt/Platform.asl. The ACPI entry is necessary for the intel_pmc_ipc driver to load up automatically on Linux.
@myguitar
Copy link
Contributor

@umaplehurst Thanks for opening this issue. We will check and add the missing device. By the way, what APL board are you using and what Linux are you using for your board?

@umaplehurst
Copy link
Contributor Author

Thanks! This is on a custom board, based on Leaf Hill CRB, kernel v4.14.

myguitar added a commit to myguitar/slimbootloader that referenced this issue Oct 17, 2019
@myguitar
[APL] Expose IPC1 device to OS
3dff698 
This patch adds IPC1 device to DSDT and exposes it to OS.
The behavior can be controlled by Config Data.
- Silicon Setting > Device Enable/Disable > Control 1 > IPC1 Enable/Disable

It also fixed slimbootloader#390.

Signed-off-by: Aiden Park <aiden.park@intel.com>
@myguitar myguitar mentioned this issue Oct 17, 2019
Merged
myguitar added a commit that referenced this issue Oct 17, 2019
@myguitar
[APL] Expose IPC1 device to OS (#402)
b7df78d 
This patch adds IPC1 device to DSDT and exposes it to OS.
The behavior can be controlled by Config Data.
- Silicon Setting > Device Enable/Disable > Control 1 > IPC1 Enable/Disable

It also fixed #390.

Signed-off-by: Aiden Park <aiden.park@intel.com>
@umaplehurst
Copy link
Contributor Author

I've done a little bit more testing:

What works: Linux can successfully use the watchdog, all good.
What doesn't work: sending IPC commands to the PMC doesn't work, the error from the Linux driver is "IPC timed out". I don't get this problem with the official IFWI CRB firmware, v227.51, sending commands to the PMC works fine there.

Please let me know if you'd like me to open this as a fresh bug instead.

@myguitar
Copy link
Contributor

I've done a little bit more testing:

What works: Linux can successfully use the watchdog, all good.
What doesn't work: sending IPC commands to the PMC doesn't work, the error from the Linux driver is "IPC timed out". I don't get this problem with the official IFWI CRB firmware, v227.51, sending commands to the PMC works fine there.

Please let me know if you'd like me to open this as a fresh bug instead.

@umaplehurst Thanks you for more testing. Please open this as a fresh issue and let us know test steps such as Linux sys node command. We will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APL] Expose IPC1 device to OS myguitar/slimbootloader
2 participants
@myguitar @umaplehurst