[CFL] Optimize Gpio Cfg Data input #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PinOffset information like PadNum, GrpIdx for a GPIO can be adjusted in the fields available in DW1, where as ChipsetId can be determined dynamically. This reduces the config data size significantly. So, we can remove PinOffset info i.e. the first dword in the GpioTableData. Moved static definitions to top of the file in Stage2 board init. Signed-off-by: Sai Talamudupula <sai.kiran.talamudupula@intel.com>
stalamudupula
force-pushed
the
CFL_GpioCln
branch
from
56cc94b
to
a1a73aa
Compare
mauricema
reviewed
Aug 8, 2019
| // | ||
| // GPIO_PAD Fileds | ||
| // | ||
| typedef struct { |
There was a problem hiding this comment.
maybe move them into header file instead
There was a problem hiding this comment.
Never mind, it is already in H file.
mauricema
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinOffset information like PadNum, GrpIdx for a GPIO can be
adjusted in the fields available in DW1, where as ChipsetId
can be determined dynamically. This reduces the config data
size significantly. So, we can remove PinOffset info i.e. the
first dword in the GpioTableData.
Moved static definitions to top of the file in Stage2 board init.
Signed-off-by: Sai Talamudupula sai.kiran.talamudupula@intel.com