Build stuck on unicode locale Windows #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myguitar
force-pushed
the
build_on_unicode_windows
branch
from
6fa26cf
to
5cde68d
Compare
GIT allows only UNIX format in .patch file. Otherwise, git am or apply will report 'fatal: git apply: bad git-diff - expected /dev/null'. But, PatchCheck blocks non-CRLF changes in commit. It's mutual exclusive. Therefore, skip CRLF check in git .patch files. Signed-off-by: Aiden Park <aiden.park@intel.com>
This issue happens under two conditions
1. Unicode language environment in Windows
2. A python calls 'BaseTools/toolsetup.bat'
(In EDKII, edksetup.bat directly in Windows command shell)
- 'BuildLoader.py' calls 'BaseTools/toolsetup.bat' in a subprocess
- 'BaseTools/toolsetup.bat' calls 'nmake cleanall'
- 'cleanall' target runs 'python NmakeSubdirs.py' directly
- 'NmakeSubdirs.py' creates multi-threads
- The threads create another subprocesses
But, one of multi-threads is on deadlock when python handles stdout and
stderr in a subprocess pipe only if the output includes unicode chars.
Therefore, only stderr will be handled in the pipe same as a single
thread call.
Signed-off-by: Aiden Park <aiden.park@intel.com>
myguitar
force-pushed
the
build_on_unicode_windows
branch
from
5cde68d
to
b117fa7
Compare
|
Are the changes for Basetool coming from EDK2 base tool? If not, should we report issue to EDK2 base tool? |
Right, the change has been made in EDK2 BaseTools. I will follow up next step. |
|
gdong1
approved these changes
Dec 11, 2019
myguitar
added a commit
to myguitar/edk2
that referenced
this pull request
Dec 11, 2019
This issue happens under two conditions. 1. Unicode language environment in Windows 2. Call 'edksetup.bat forcerebuild' with python subprocess.call() Steps to reproduce C:\edk2>python Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:24:40) Type help, copyright, credits or license for more information. >>> import subprocess >>> subprocess.call(['edksetup.bat', 'forcerebuild']) The edksetup.bat stuck at 'nmake cleanall'. One of multi-threads is on deadlock when python handles stdout and stderr in a subprocess pipe only if the outputs include unicode chars. Only stderr will be handled in the pipe same as a single thread call. Reported in Slim Bootloader. slimbootloader/slimbootloader#478 Local fix has been made in Slim Bootloader. slimbootloader/slimbootloader#490 Signed-off-by: Aiden Park <aiden.park@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happens under two conditions
(In EDKII, edksetup.bat directly in Windows command shell)
But, one of multi-threads is on deadlock when python handles stdout and
stderr in a subprocess pipe only if the output includes unicode chars.
Therefore, only stderr will be handled in the pipe same as a single
thread call.
Signed-off-by: Aiden Park aiden.park@intel.com