chore: 修正一个测试用例

slimkit · Aug 15, 2019 · 6b25dc7 · 6b25dc7
1 parent 4da4008
commit 6b25dc7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/app/Http/Controllers/APIs/V2/AuthController.php b/app/Http/Controllers/APIs/V2/AuthController.php
@@ -65,9 +65,8 @@ public function login(Request $request)
         $login = (string) $request->input('login', '');
         $code = $request->input('verifiable_code');
         $field = username($login);
-
         if ($code !== null && in_array($field, ['phone', 'email'])) {
-            $verify = VerificationCode::where('account', $login)
+            $verify = VerificationCode::query()->where('account', $login)
                 ->where('channel', $field == 'phone' ? 'sms' : 'mail')
                 ->where('code', $code)
                 ->byValid(120)
@@ -114,7 +113,7 @@ public function login(Request $request)
                 return $this->respondWithToken($token);
             }
 
-            return $this->response()->json(['message' => '账号或密码不正确'], 422);
+            return $this->response()->json(['message' => '账号或密码不正确'], 403);
         } else {
             return $this->response()->json([
                 'message' => sprintf('%s还没有注册', $field == 'phone'

diff --git a/database/factories/UserFactory.php b/database/factories/UserFactory.php
@@ -36,7 +36,7 @@
         'name' => $faker->name,
         'email' => $faker->unique()->safeEmail,
         'phone' => $faker->unique()->phoneNumber,
-        'password' => $password ?: $password = bcrypt('secret'),
+        'password' => $password ?: $password = bcrypt('password'),
         'email_verified_at' => now(),
         'phone_verified_at' => now(),
         'remember_token' => str_random(10),

diff --git a/tests/Feature/API2/AuthLoginTest.php b/tests/Feature/API2/AuthLoginTest.php
@@ -47,12 +47,25 @@ public function testUserLogin()
     {
         $response = $this->json('POST', 'api/v2/auth/login', [
             'login' => $this->user->id,
-            'password' => 'secret',
+            'password' => 'password',
         ]);
 
         $this->assertLoginResponse($response);
     }
 
+    /**
+     * 使用错误的密码将返回403状态码
+     */
+    public function test_user_can_not_login_with_wrong_password()
+    {
+        $response = $this->json('POST', 'api/v2/auth/login', [
+            'login' => $this->user->id,
+            'password' => 'secret',
+        ]);
+
+        $response->assertStatus(403);
+    }
+
     /**
      * Assert login response.
      *