Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Man page implies '--dir' option is recursive #54

Closed
CalumMcCall opened this issue Dec 6, 2017 · 3 comments
Closed

Man page implies '--dir' option is recursive #54

CalumMcCall opened this issue Dec 6, 2017 · 3 comments

Comments

@CalumMcCall
Copy link

The man page states:

-d or --dir
Recursively checks all executable files in the directory for security features compiled
into the executables

I'm not sure what's meant exactly by this statement, as in my tests, checksec does not check subdirectories recursively. It only checks executables in the directory given. Is this intended behaviour? My expectation was that it would recursively check subdirectories.
@slimm609
Copy link
Owner

give it a try now. should be fixed

@rc-matthew-l-weber
Copy link

rc-matthew-l-weber commented May 23, 2018 •
edited

One other bug with this. Please use . instead of $(tempdir) in the find () used to locate all the files. Then you can use relative paths

2b15861#diff-4de72339214a2b81caab117fb4aac50aR1194

2b15861#diff-4de72339214a2b81caab117fb4aac50aR1202

@rc-matthew-l-weber rc-matthew-l-weber mentioned this issue May 23, 2018
Closed
@slimm609
Copy link
Owner

Tested and can not reproduce this issue. closing

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue Aug 3, 2019
@ffontaine @tpetazzoni
package/checksec: bump to version 2.1.0
2467822 
Remove patch, it does not seem to be needed anymore as issue was not
reproduced (see slimm609/checksec.sh#54)

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CalumMcCall @slimm609 @rc-matthew-l-weber