-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component name #1
Comments
I vote |
I don't have any strong feelings about this. But since the repository is already named |
The repo is brand new & can be changed.. It's a given that we'd match namespace name :) |
|
Slim\Psr7 +1 |
raigu
added a commit
to raigu/Slim-Psr7
that referenced
this issue
Apr 7, 2021
Line UploadedFile.php ------ ----------------------------------------------------------------------------------------------- 175 Parameter slimphp#1 $source of function stream_copy_to_stream expects resource, resource|null given. 175 Parameter slimphp#2 $dest of function stream_copy_to_stream expects resource, resource|false given.
raigu
added a commit
to raigu/Slim-Psr7
that referenced
this issue
Apr 7, 2021
Line UploadedFile.php ------ ---------------------------------------------------------------------------------------------- 179 Parameter slimphp#2 $dest of function stream_copy_to_stream expects resource, resource|false given. 181 Parameter slimphp#1 $fp of function fclose expects resource, resource|false given. ------ ---------------------------------------------------------------------------------------------- Had to force to skip target writability test in order to conduct a test that PHPStan required in a way that the 100% code coverage would be remain intact.
raigu
added a commit
to raigu/Slim-Psr7
that referenced
this issue
Apr 7, 2021
Demonstration of error before fix: $ ./vendor/bin/phpstan analyse src Note: Using configuration file /home/rait/dev/gs/Slim-Psr7/phpstan.neon.dist. 18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ -------------------------------------------------------------------------------------------------------------------------------------------------------- Line Factory/StreamFactory.php ------ -------------------------------------------------------------------------------------------------------------------------------------------------------- 74 Parameter slimphp#1 $callback of function set_error_handler expects (callable(int, string, string, int, array): bool)|null, Closure(int, string): null given. ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We can't use
Slim\Http
as we need that for Slim itself.Options:
Slim\Psr7
Slim\HttpMessage
The text was updated successfully, but these errors were encountered: