Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component name #1

Closed
akrabat opened this issue Dec 12, 2016 · 5 comments
Closed

Component name #1

akrabat opened this issue Dec 12, 2016 · 5 comments

Comments

@akrabat
Copy link
Member

akrabat commented Dec 12, 2016

We can't use Slim\Http as we need that for Slim itself.

Options:

  1. Slim\Psr7
  2. Slim\HttpMessage
@codeguy
Copy link
Member

codeguy commented Dec 12, 2016

I vote Slim\Psr7.

@tuupola
Copy link
Contributor

tuupola commented Dec 12, 2016

I don't have any strong feelings about this. But since the repository is already named Slim-Psr7 class name should also be Slim\Psr7 or OCD kicks in.

@akrabat
Copy link
Member Author

akrabat commented Dec 12, 2016

The repo is brand new & can be changed.. It's a given that we'd match namespace name :)

@mathmarques
Copy link

Slim\Psr7 +1

@xcorp1986
Copy link

Slim\Psr7 +1

@akrabat akrabat closed this as completed Jan 10, 2017
@jnessier jnessier mentioned this issue Jul 26, 2020
Closed
raigu added a commit to raigu/Slim-Psr7 that referenced this issue Apr 7, 2021
@raigu
Fix PHPStan warnings
d8416c2 
 Line   UploadedFile.php
 ------ -----------------------------------------------------------------------------------------------
  175    Parameter slimphp#1 $source of function stream_copy_to_stream expects resource, resource|null given.
  175    Parameter slimphp#2 $dest of function stream_copy_to_stream expects resource, resource|false given.
raigu added a commit to raigu/Slim-Psr7 that referenced this issue Apr 7, 2021
@raigu
Fix PHPStan warnings
f38d12e 
 Line   UploadedFile.php
 ------ ----------------------------------------------------------------------------------------------
  179    Parameter slimphp#2 $dest of function stream_copy_to_stream expects resource, resource|false given.
  181    Parameter slimphp#1 $fp of function fclose expects resource, resource|false given.
 ------ ----------------------------------------------------------------------------------------------

Had to force to skip target writability test in order to conduct a test that PHPStan required in a way that the 100% code coverage would be remain intact.
raigu added a commit to raigu/Slim-Psr7 that referenced this issue Apr 7, 2021
@raigu
Fix PHPStan error about set_error_handler
2e62c8c 
Demonstration of error before fix:

$ ./vendor/bin/phpstan analyse src
Note: Using configuration file /home/rait/dev/gs/Slim-Psr7/phpstan.neon.dist.
 18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Factory/StreamFactory.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
  74     Parameter slimphp#1 $callback of function set_error_handler expects (callable(int, string, string, int, array): bool)|null, Closure(int, string): null given.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tuupola @codeguy @akrabat @mathmarques @xcorp1986