Use the code passed to ActionPayload for the HTTP status code #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
approved these changes
May 4, 2020
l0gicgate
requested changes
May 4, 2020
| { | ||
| return $this->respondWithData( | ||
| [ | ||
| 'willBeDoneAt' => (new \DateTimeImmutable())->format(\DateTimeImmutable::ATOM) |
There was a problem hiding this comment.
please fix those two references as well and use new DateTimeImmutable()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we pass a status code to the constructor of the ActionPayload class it is only used as a field in our json response. If we don't provide an error to the constructor, the HTTP code is always 200. It doesn't work for all scenarios. In some cases I would return the code 202 and provide information on when the action will be fully completed.