Remove HTTP method case-insensitivity from Router

[akrabat]

As per https://tools.ietf.org/html/rfc7230#section-3.1.1, HTTP methods are case-sensitive.

Therefore we need to remove:

        // According to RFC methods are defined in uppercase (See RFC 7231)
        $methods = array_map("strtoupper", $methods);

From Slim\Router

[vlakoff]

"Be resilient in what you receive, and strict in what you send".

PHP user code and HTTP header sent are not the same "layer" and don't have to be that tied.

I'd bend keeping this strtoupper.

[akrabat]

However, $app->map('foo', FooHandler::class') has to match to the HTTP method foo, not FOO.

[JeanPaiva]

@akrabat can I get this one?

[akrabat]

@JeanPaiva Sure.

[vlakoff]

Shouldn't the issue be titled "Remove HTTP method case-insensitivity from Router"?

[JeanPaiva]

Now $router->map(['get'], '/foo', 'foo:bar'); will return Slim\Exception\HttpNotFoundException.
It's correct?
PR #2507

[vlakoff]

My comment above had been too fast.

I hadn't understood there is no change for the simple use case: the user will continue to do $app->get().

[vlakoff]

@JeanPaiva In theory yes, but it depends on the HTTP server, which may be tolerant on the case. But in practice, yes, they seem to follow the specs, and reject the request.

[akrabat]

Fixed by #2507.