Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP method case-insensitivity from Router #2507

Merged
merged 2 commits into from Nov 25, 2018

Conversation

Projects
None yet
3 participants
@JeanPaiva
Copy link

commented Sep 25, 2018

Now $router->map(['get'], '/foo', 'foo:bar'); will return Slim\Exception\HttpNotFoundException

@coveralls

This comment has been minimized.

Copy link

commented Sep 25, 2018

Coverage Status

Coverage decreased (-0.004%) to 97.385% when pulling 1a63671 on JeanPaiva:issue-2500 into 6088d8c on slimphp:4.x.

@JeanPaiva

This comment has been minimized.

Copy link
Author

commented Sep 28, 2018

What would be this the correct way to test this PR?
d54b5ba

@akrabat akrabat added the Slim 4 label Nov 25, 2018

@akrabat

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

Rebased

@akrabat akrabat merged commit 1a63671 into slimphp:4.x Nov 25, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.004%) to 97.385%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Nov 25, 2018

akrabat added a commit that referenced this pull request Nov 25, 2018

@akrabat

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

Thank you.

@akrabat akrabat added this to the 4.0 milestone Nov 25, 2018

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.