Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTTP method case-insensitivity from Router #2507

Merged
merged 2 commits into from Nov 25, 2018
Merged

Remove HTTP method case-insensitivity from Router #2507

merged 2 commits into from Nov 25, 2018

Conversation

JeanPaiva
Copy link
Contributor

Now $router->map(['get'], '/foo', 'foo:bar'); will return Slim\Exception\HttpNotFoundException

@coveralls
Copy link

coveralls commented Sep 25, 2018 •
edited

Coverage Status

Coverage decreased (-0.004%) to 97.385% when pulling 1a63671 on JeanPaiva:issue-2500 into 6088d8c on slimphp:4.x.

@JeanPaiva JeanPaiva closed this Sep 25, 2018
@JeanPaiva JeanPaiva mentioned this pull request Sep 25, 2018
Closed
@JeanPaiva JeanPaiva reopened this Sep 28, 2018
@JeanPaiva
Copy link
Contributor Author

JeanPaiva commented Sep 28, 2018 •
edited

What would be this the correct way to test this PR?
d54b5ba

@akrabat akrabat added the Slim 4 label Nov 25, 2018
@akrabat
Copy link
Member

akrabat commented Nov 25, 2018

Rebased

@akrabat akrabat merged commit 1a63671 into slimphp:4.x Nov 25, 2018
akrabat added a commit that referenced this pull request Nov 25, 2018
@akrabat
Update CHANGELOG for #2507
4eb55c7
akrabat added a commit that referenced this pull request Nov 25, 2018
@akrabat
Merge branch 'issue-2500' into 4.x
4d8f304 
Closes #2507
@akrabat
Copy link
Member

akrabat commented Nov 25, 2018

Thank you.

@akrabat akrabat added this to the 4.0 milestone Nov 25, 2018
@l0gicgate l0gicgate mentioned this pull request Apr 25, 2019
Merged
@l0gicgate l0gicgate mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeanPaiva @coveralls @akrabat