Update Router.php adding internalPathFor

[pokmot]

Suggested code update for issue #1521

[akrabat]

We still need pathFor().

The implementation of pathFor() should be:

    /**
     * Build the path for a named route including the base path
     *
     * @param string $name        Route name
     * @param array  $data        Named argument replacement data
     * @param array  $queryParams Optional query string parameters
     *
     * @return string
     *
     * @throws RuntimeException         If named route does not exist
     * @throws InvalidArgumentException If required data not provided
     */
    public function pathFor($name, array $data = [], array $queryParams = [])
    {
        $url = $this->internalPathFor($name, $data, $queryParams);

        if ($this->basePath) {
            $url = $this->basePath . $url;
        }

        return $url;
    }

Also, we need unit tests for internalPathFor

[akrabat]

Superseded by #1552