Implement internalPathFor() #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2015
|
Would this not be relative and absolute pathFor, I am not sure about the current name as its a public method saying its internal, when its accessible externally. |
|
Valid point. I'm not especially keen on renaming |
This method is mostly useful when using `subRequest` which does not expect the base path. Closes #1521
|
Renamed. |
silentworks
added a commit
that referenced
this pull request
Oct 23, 2015
Implement internalPathFor()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is mostly useful when using
subRequestwhich does notexpect the base path.
Closes #1521