New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if calling a non-existing method on App #1706

Merged
merged 1 commit into from Jan 1, 2016

Conversation

Projects
None yet
3 participants
@mnapoli
Contributor

mnapoli commented Dec 28, 2015

I've got bitten by this with a project that was compatible with an early beta of Slim 3:

$app->addMiddleware(function (...) {
       ...
});

No error was thrown even though I called a non-existing method because of the specific __call() implementation.

With this change, an error will be thrown when calling an unknown method on App.

@silentworks silentworks added this to the 3.1.0 milestone Dec 28, 2015

@akrabat akrabat merged commit afd61ab into slimphp:3.x Jan 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Jan 1, 2016

@mnapoli mnapoli deleted the mnapoli:patch-1 branch Jan 1, 2016

rivetchip pushed a commit to rivetchip/Slim that referenced this pull request Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment