Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor callable resolver, router, route, and route group #2098

Merged
merged 13 commits into from
Dec 11, 2016
Merged

Refactor callable resolver, router, route, and route group #2098

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
89329e5
Add callable resolver setter/getter methods on App
codeguy Dec 10, 2016
2072aff
Merge remote-tracking branch 'upstream/4.x' into feature-refactor-cal…
codeguy Dec 10, 2016
1e80bbc
Refactor DeferredCallable
codeguy Dec 10, 2016
d29420c
Bind closure callables to container in our own resolver
codeguy Dec 10, 2016
04aeb66
Let App use new callable resolvers with middlewares
codeguy Dec 10, 2016
554a605
Pass callable resolver into router in our old service provider
codeguy Dec 10, 2016
3d5fd1f
Refactor router, route, route group for new callable resolver
codeguy Dec 10, 2016
2f792ba
Refactor App for new router and callable resolver
codeguy Dec 10, 2016
767a9c9
Remove testing code
codeguy Dec 10, 2016
f9f4953
Remove container from App::setCallableResolver
codeguy Dec 10, 2016
dee7269
Remove container out of App::getRouter()
codeguy Dec 10, 2016
c9c37a5
Add UPGRADING.md file
codeguy Dec 11, 2016
cd1a3e3
Update upgrade language
codeguy Dec 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# How to upgrade

* [2098] - You must inject the container router into app with `$app->setRouter()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, you need to add the App's router to the container for a straight upgrade. If you've created your own router factory in the container though, then you need to set it into the $app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated language


[2098]: 92612999931799571752400592