Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on Slim-Http #2221

Merged
merged 4 commits into from May 17, 2017

Conversation

Projects
None yet
5 participants
@akrabat
Copy link
Member

commented May 8, 2017

Remove Slim\Http from this repository and depend on Slim-Http

Note that this change requires slimphp/Slim-Http#24 to be released as version 0.2, first.

akrabat added some commits May 7, 2017

Use Http’s createFromGlobals() methods
This replaces createFromEnvironment() and also means that we no longer
need the `environment` key in the container.

@akrabat akrabat requested a review from geggleto May 8, 2017

@akrabat akrabat assigned codeguy and silentworks and unassigned codeguy and silentworks May 8, 2017

@akrabat akrabat requested review from codeguy and silentworks May 8, 2017

@akrabat

This comment has been minimized.

Copy link
Member Author

commented May 8, 2017

Travis is failing as the composer requirement cannot be met yet.

@coveralls

This comment has been minimized.

Copy link

commented May 14, 2017

Coverage Status

Coverage decreased (-2.08%) to 94.138% when pulling a7362be on akrabat:slim-http into 54401a4 on slimphp:4.x.

@akrabat

This comment has been minimized.

Copy link
Member Author

commented May 14, 2017

@codeguy, @silentworks, @geggleto: Travis passes now that Slim-Http 0.2 is released.

Please review.

@geggleto geggleto added the Slim 4 label May 15, 2017

@@ -57,7 +44,7 @@ public function register($container)
* @return ServerRequestInterface
*/
$container['request'] = function ($container) {
return Request::createFromEnvironment($container->get('environment'));
return Request::createFromGlobals($_SERVER);

This comment has been minimized.

Copy link
@geggleto

geggleto May 15, 2017

Contributor

grumble

@silentworks silentworks merged commit 72eea92 into slimphp:4.x May 17, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-2.08%) to 94.138%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

l0gicgate added a commit to l0gicgate/Slim that referenced this pull request May 17, 2017

@akrabat akrabat added this to the 4.0 milestone Aug 24, 2018

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.