Depend on Slim-Http #2221
Merged
Depend on Slim-Http #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces createFromEnvironment() and also means that we no longer need the `environment` key in the container.
|
Travis is failing as the composer requirement cannot be met yet. |
|
@codeguy, @silentworks, @geggleto: Travis passes now that Slim-Http 0.2 is released. Please review. |
geggleto
approved these changes
May 15, 2017
| @@ -57,7 +44,7 @@ public function register($container) | |||
| * @return ServerRequestInterface | |||
| */ | |||
| $container['request'] = function ($container) { | |||
| return Request::createFromEnvironment($container->get('environment')); | |||
| return Request::createFromGlobals($_SERVER); | |||
silentworks
approved these changes
May 17, 2017
l0gicgate
added a commit
to l0gicgate/Slim
that referenced
this pull request
May 17, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Slim\Httpfrom this repository and depend on Slim-HttpNote that this change requires slimphp/Slim-Http#24 to be released as version 0.2, first.