Sync to Slim\Http in 4.x #24
Conversation
Pending decision on if we’re going to go PHP 7+ only…
Rename createFromEnvironment() to createFromGlobals() and make it take an array, rather than an Environment object. This means the Environment is only required for testing.
| @@ -12,7 +12,7 @@ | |||
| * Headers Interface | |||
| * | |||
| * @package Slim | |||
| * @since 3.0.0 | |||
| * @since 1.0.0 | |||
There was a problem hiding this comment.
Should this not be 3.0.0 as it was before? we only got HeadersInterface in Slim 3?
There was a problem hiding this comment.
My view was that this will be since 1.0 of Slim-Http.
Arguably the package should be Slim-Http though?
|
In theory this looks pretty good. |
| "psr/http-message": "^1.0" | ||
| }, | ||
| "require-dev": { | ||
| "squizlabs/php_codesniffer": "^2.5", | ||
| "phpunit/phpunit": "^5.7|^6.0" | ||
| }, | ||
| "conflict": { | ||
| "slim/slim": "^3.0" |
There was a problem hiding this comment.
Should this not be slim/slim ^4.0 as we will have namespacing conflicts?
There was a problem hiding this comment.
Nope. Slim 4 won't have any of the Slim\Http namespace in it.
There was a problem hiding this comment.
but say I include slim/http in a Slim 3 project ... ?
There was a problem hiding this comment.
Oh my bad... it says conflict xD
Forward port of slimphp/Slim#2213
composer.json
Outdated
| "phpunit/phpunit": "^5.7|^6.0" | ||
| }, | ||
| "conflict": { | ||
| "slim/slim": "^3.0" | ||
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "Slim\\Http\\": "src", | ||
| "Slim\\Http\\": "src" |
There was a problem hiding this comment.
I think from composer docs it says the path should have a / after it, so it should be "src/"
Pick up all the changes to Slim\Http in Slim 4 by copying the code from Slim 4.x into this repository.
Notes:
createFromEnvironmenttocreateFromGlobalsrenameFactoryDefaultfactory class.