Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate routing from dispatching #2288

Merged
merged 4 commits into from
Aug 17, 2017
Merged

Separate routing from dispatching #2288

merged 4 commits into from
Aug 17, 2017

Commits on Aug 17, 2017

  1. Separate routing from dispatching 

    Move the routing to middleware so that the user can add it wherever they
want it to be within the middleware stack. This gives us the new
capability to allow for some middleware to run before routing and some
after.

If the `Routing` middleware isn't added by the user, then automatically
call it in `App::__invoke()` as a last resort.

Also, remove `determineRouteBeforeAppMiddleware` setting as it's no
longer necessary.
    @akrabat
    akrabat committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    e7ed8dc View commit details
    Browse the repository at this point in the history

  2. Rename to RoutingMiddleware

    @akrabat
    akrabat committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    a8fe6a2 View commit details
    Browse the repository at this point in the history

  3. Rename doRouting to performRouting 

    Also update comment to be clearer.
    @akrabat
    akrabat committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7ff1c47 View commit details
    Browse the repository at this point in the history

  4. Update UPGRADING and CHANGELOG

    @akrabat
    akrabat committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    0c3eb5d View commit details
    Browse the repository at this point in the history