Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis by GitHub Actions #3037

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Replace Travis by GitHub Actions #3037

merged 1 commit into from
Dec 8, 2020

Conversation

t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Dec 3, 2020

I just don't know if you want to use differents jobs for our differents tools (phpcs, phpstan, phpunit,...)

Fix #3035

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@l0gicgate
Copy link
Member

It seems that this PR is still in draft. Looks good to me though, I'd like to see the actions run before merging.

@t0mmy742
Copy link
Contributor Author

t0mmy742 commented Dec 8, 2020

@l0gicgate you can see GitHub Actions running just here
It looks good to me, I rebased everything.

@j0k3r
Copy link
Contributor

j0k3r commented Dec 8, 2020

@l0gicgate I think you might need to enable GitHub Actions somewhere in the settings of the slimphp's organization

@l0gicgate
Copy link
Member

@j0k3r they are already enabled. Maybe after this is merged they will run. I'll try it now.

@l0gicgate l0gicgate added this to the 4.8.0 milestone Dec 8, 2020
@l0gicgate
Copy link
Member

Thanks for your contribution @t0mmy742

@l0gicgate l0gicgate merged commit d641d0b into slimphp:4.x Dec 8, 2020
@l0gicgate
Copy link
Member

First run went fantastic. We should do this on all the other repos!

https://github.com/slimphp/Slim/actions/runs/409168671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI to GitHub Actions
3 participants