-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a separate extension for helper functions #22
Conversation
The method name seem to communicate one thing while doing something else IMO. I would actually prefer to register the extension manually and doing it externally. |
You mean I kept that so that the set up of the extension remains: $container->register(new \Slim\Views\Twig('path/to/templates', [
'cache' => 'path/to/cache'
])); which is nice and simple to use. I'm not wedded to it though and am happy enough to remove the method and change the README. |
if thats the case its probably better to make that method Although saying that, I still think most users are happy to register it themselves as this is how Slim-Views currently works plus it is easier to override |
Also add base_url Twig function.
c8703ba
to
f8f893d
Compare
Rebased, removed |
f8f893d
to
1a5634d
Compare
The README doesn't look correct to me. |
cf0bda5
to
940431a
Compare
Try now! |
Create a separate extension for helper functions
Also add
base_url
Twig function.