This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Initial refactor to monorepo-y folder structure #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for slinkity canceled. 🔨 Explore the source changes: a8cca8a 🔍 Inspect the deploy log: https://app.netlify.com/sites/slinkity/deploys/61deddf046ed8d0008ebe15e |
ghost
reviewed
Jan 12, 2022
There was a problem hiding this comment.
These changes look great! Gonna make a couple follow-up commits here to:
- migrate our base
package.jsonand all associated files inside ofpackages/slinkity. This ensures a "true" monorepo setup once we get into workspaces (out of scope) - expand our eslint config to include
create-slinkityas well - update the
CONTRIBUTINGguide to explain where to find things
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the first three of four refactors described in #119.
docs/becomeswww/to encompass everything on slinkity.dev.src/becomes a nestedslinkitydirectory underpackages/.create-slinkityis pulled in from (currently separate) slinkity-starter repo.slinkity-renderer-Xare free to live inpackagesas they're built out.All tests described in the contributing guide's automated test suites are passing. Not sure what the implications of these changes will be for the deployed docs site, so let me know if other stuff breaks.