This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Accessibility for contributors table #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for slinkity ready! 🔨 Explore the source changes: c3e67b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/slinkity/deploys/61e442ee4a204f0008f87914 😎 Browse the preview: https://deploy-preview-135--slinkity.netlify.app |
ghost
approved these changes
Jan 17, 2022
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the contributors table was using
<h4>elements to give contributor usernames extra prominence. Since theh4s weren't being used for sectioning, I've removed theh4s around the username links and given the username linksdisplay: block;,font-weight: bold, and the appropriate margins to emulate the same appearance those links had inside anh4.I've also added an
aria-describedbyon the username links, pointing to the contributor's title. This means that if someone is tabbing through the contributor links while using a screenreader, if they choose to linger on a link, it will announce their title as supplementary information:Holben888, link, Supreme Slinkity Stan. More info at https://benmyers.dev/blog/aria-labels-and-descriptions/