-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
energy monitor example fails to run on Android 12 #5031
Comments
As a random member of the public, I do not have push access to this public repository (which is understandable), so I could not create a pull request. Here is a diff that captures my fix for the issue.
|
Make the code by @matthewjrichey found in issue slint-ui#5031 into a PR: > [...] discovered that `AMotionEvent_getActionButton` is only available on > Android NDK 33 (Android 13) or higher. I came up with a working fix for the > problem, which is tested and working on Android 12. Done-by: @matthewjrichey
I took the liberty to turn this diff into a PR here: #5047 for your review-conveninece. The code looks sensible to me, but I have no Android setup here (nor a Android 12 device) to test this with. @matthewjrichey: You can clone the repo, push your code into your own clone and then create a PR from that. This approach is not limited to Slint, it works for any project on github, just in case you run into the situation again. |
Thank you for your time and contribution. I think this is small enough to count as a "simple fix" and not need the full CLA dance, which my PR goes around... |
Make the code by @matthewjrichey found in issue #5031 into a PR: > [...] discovered that `AMotionEvent_getActionButton` is only available on > Android NDK 33 (Android 13) or higher. I came up with a working fix for the > problem, which is tested and working on Android 12. Done-by: @matthewjrichey
Slint release tested: 1.6.0
Command used to build example:
cargo apk build -p energy-monitor --target x86_64-linux-android --lib
Executed on emulated Android 12 (x86_64) and actual Android 12 device (aarch64).
Failure (captured with
adb logcat
):Researched and discovered that
AMotionEvent_getActionButton
is only available on Android NDK 33 (Android 13) or higher. I came up with a working fix for the problem, which is tested and working on Android 12. I will file the fix as a PR.The text was updated successfully, but these errors were encountered: