Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Support Android 12 #5047

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

hunger
Copy link
Member

@hunger hunger commented Apr 12, 2024

Make the code by @matthewjrichey found in issue #5031 into a PR:

[...] discovered that AMotionEvent_getActionButton is only available on
Android NDK 33 (Android 13) or higher. I came up with a working fix for the
problem, which is tested and working on Android 12.

Done-by: @matthewjrichey

Closes #5031

Make the code by @matthewjrichey found in issue slint-ui#5031 into a PR:

> [...] discovered that `AMotionEvent_getActionButton` is only available on
> Android NDK 33 (Android 13) or higher. I came up with a working fix for the
> problem, which is tested and working on Android 12.

Done-by: @matthewjrichey
@hunger
Copy link
Member Author

hunger commented Apr 12, 2024

NOTE: I think this is small enough to count as a simple fix that does not absolutely need a CLA.

I will not push this without some confirmation that this is indeed the case or a statement that @matthewjrichey has signed the CLA.

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This is better than the quick and dirty fix i did in a branch for EW (commit 52ead8e)

@ogoffart ogoffart merged commit 8a19e13 into slint-ui:master Apr 12, 2024
36 checks passed
@matthewjrichey
Copy link

Hello team, thank you for having a look at this. I ran into the issue when developing a small hobby project that is targeted for some home devices that are running Android 12. I would be happy to test the merged fix and let you know what I find, if that would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

energy monitor example fails to run on Android 12
3 participants