-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler panic compiling init
callback from a component inlined into a repeater
#5146
Labels
Comments
Thanks for the bug report. |
Option::unwrap()
on a None
value"init
callback from a component inlined into a repeater
ogoffart
added a commit
that referenced
this issue
Apr 29, 2024
The problem was that the code from #4322 inlined the init code in the parent Component as at that point, the per-repeater component don't exist yet. Fix it by removing the workaround from #4322, but changing the order of the passes so that the init code are already proccessed before any inlining. This required to change the order of a bunch of passes. Fixes #5146 As a drive-by, also add the missing C++ implementation of set_animated_value for Brush that was discovered by the test. (Code wouldn't compile)
ogoffart
added a commit
that referenced
this issue
Apr 29, 2024
The problem was that the code from #4322 inlined the init code in the parent Component as at that point, the per-repeater component don't exist yet. Fix it by removing the workaround from #4322, but changing the order of the passes so that the init code are already proccessed before any inlining. This required to change the order of a bunch of passes. Fixes #5146 As a drive-by, also add the missing C++ implementation of set_animated_value for Brush that was discovered by the test. (Code wouldn't compile)
ogoffart
added a commit
that referenced
this issue
Apr 29, 2024
The problem was that the code from #4322 inlined the init code in the parent Component as at that point, the per-repeater component don't exist yet. Fix it by removing the workaround from #4322, but changing the order of the passes so that the init code are already proccessed before any inlining. This required to change the order of a bunch of passes. Fixes #5146 As a drive-by, also add the missing C++ implementation of set_animated_value for Brush that was discovered by the test. (Code wouldn't compile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I randomly found a bug in the compiler that panics with the following message:
It appears under some weird circumstances. I was able to reproduce it like this:
For example:
That bug also appears in SlintPad, it freezes the preview window and prints a similar error message in the JS console.
The text was updated successfully, but these errors were encountered: