Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ChangeLog #1612

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Update ChangeLog #1612

merged 2 commits into from
Sep 8, 2022

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Sep 8, 2022

No description provided.

tronical
tronical approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mixture of sentences ending with a period and without. I think that all sentences should end with a period in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ogoffart @tronical
Apply suggestions from code review
81f514b 
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
@ogoffart ogoffart merged commit 6621f3a into master Sep 8, 2022
@ogoffart ogoffart deleted the olivier/docs branch September 8, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogoffart @tronical