Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare the Slint VS code extension as stable #2212

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Declare the Slint VS code extension as stable #2212

merged 1 commit into from
Feb 9, 2023

Conversation

tronical
Copy link
Member

@tronical tronical commented Feb 9, 2023

... and not preview anymore.

ogoffart
ogoffart approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the nightly extension keep the preview though?

(I've seen other extension publishing unstable versions somehow with the same name, maybe we should do the same?)

@tronical
Copy link
Member Author

tronical commented Feb 9, 2023

You're right. That means prepare_vscode_nightly.sh should re-add it. I'll give it a try.

@tronical
Declare the Slint VS code extension as stable
b4bc08c 
... and not preview anymore, for releases.
@tronical tronical merged commit 1bd0e47 into master Feb 9, 2023
@tronical tronical deleted the simon/vscode-mark-stable branch February 9, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tronical @ogoffart