Enable support for additional image formats (webp, etc.) in the viewer, previewer, and nodejs bindings #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Mar 23, 2023
api/wasm-interpreter/Cargo.toml
Outdated
| @@ -28,6 +28,9 @@ js-sys = "0.3.44" | |||
| wasm-bindgen-futures = { version = "0.4.18" } | |||
| wasm-bindgen = { version = "0.2.66" } | |||
|
|
|||
| # Enable image-rs' default features to make all image formats available for the wasm interpreter | |||
| image = { version = "0.24.0" } | |||
There was a problem hiding this comment.
Wait... Don't we load the image with the element on wasm. I don't think we need that then.
There was a problem hiding this comment.
Ah that's true. Good point! I'll remove that again.
…r, previewer, and nodejs bindings
tronical
force-pushed
the
simon/image-formats-preview
branch
from
55a8fdf
to
36d6b00
Compare
tronical
changed the title
ogoffart
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.