Fix memory corruption when loading encoded embedded images in C++ #2542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImageCacheKey enum has a gap when not targeting wasm:
In the C++ generated header, that cfg was not mapped, and thus the URL variant was always there, while in a regular slint-cpp build it's not. Consequently tag value 2 in Rust was used to represent the EmbeddedData variant, while in the C++ generated code that become variant 3 and 2 was interpreted as a URL. So the receiving code in C++ tried to interpret the cache key as URL variant, while Rust created it as EmbeddedData.