Improve robustness of Skia OpenGL renderer in case of GL context loss #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unlikely-yet-seen-before scenarion that we've lost the OpenGL context and can't make it current anymore in the destructor, gracefully conveny this crucial information to Skia and don't panic.
Only attempt to make the GL context current if we have a rendering notifier callback. The activation may still fail, and the API will still report it though.
ogoffart
approved these changes
Jun 30, 2023
| self.ensure_context_current().expect("Skia OpenGL Renderer: Failed to make OpenGL context current before deleting graphics resources"); | ||
| // In the event that this fails for some reason (lost GL context), convey that to Skia so that it doesn't try to call | ||
| // glDelete*** | ||
| if self.ensure_context_current().is_err() { |
There was a problem hiding this comment.
Shouldn't we somehow log this as an error?
There was a problem hiding this comment.
I'm not sure. We could print something to stderr, but the actual error (context loss) happened a lot earlier.
There was a problem hiding this comment.
Differently put: We could also always call abandon() - the resources will be deleted anyway by the context that we own. It's just us playing nice :)
|
(I'll merge this given circumstances, but happy to continue the discussion how to fine-tune this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle a loss before destruction time and reduce the chance of hide() failing to those applications that use a rendering notifier (only those might actually be interested in this error anyway).