-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic when code in init callback of conditional/repeater re-triggers repeater traversal #3215
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is a way to un-borrow the inner when calling the init methods.
Alternative could be to try to detect recursion and bail out?
let mut inner = self.0.inner.borrow_mut(); | ||
inner.components.resize_with(count, || (RepeatedComponentState::Dirty, None)); | ||
let offset = inner.offset; | ||
let mut any_items_created = false; | ||
for (i, c) in inner.components.iter_mut().enumerate() { | ||
if c.0 == RepeatedComponentState::Dirty { | ||
let created = if c.1.is_none() { | ||
if c.1.is_none() { | ||
any_items_created = true; | ||
c.1 = Some(init()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this call to init() also recurse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, true, there's probably a way of doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think just by adding another layer:
// added if true there:
if true: layout := VerticalLayout {
if true: TextInput {
// Trigger a call into the layout
init => { debug(self.y); }
}
}
But maybe self.y don't cross layers, but some other properties certainly will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how to fix this. I mean, I made a local change to separate out the init() creation without borrowing the inner, but conceptually this would still recurse because the dirty() flag is true.
Perhaps like this?
- Replace inner.components with an empty vec; set dirty to false.
- Update any dirty components, call init, etc() - during that time any recursion will find an empty repeater.
- Replace inner.components with the updated vec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe keep a Vec of ItemTreeRc and init them when the RefCell is not borrowed?
b46477e
to
d4028f6
Compare
(just a rebase for now) |
…ers repeater traversal Don't call init() while mutably borrowing the repeater's inner. Fixes #3214
d4028f6
to
c2c2294
Compare
Don't call init() while mutably borrowing the repeater's inner.
Fixes #3214