Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slok/go-http-metrics SLI plugins #9

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Add slok/go-http-metrics SLI plugins #9

merged 2 commits into from
Jun 7, 2021

Conversation

slok
Copy link
Owner

@slok slok commented Jun 7, 2021

No description provided.

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok
Copy link
Owner Author

slok commented Jun 7, 2021

Codecov Report

Merging #9 (17491ce) into main (3486521) will decrease coverage by 4.39%.
The diff coverage is 85.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   95.00%   90.60%   -4.40%     
==========================================
  Files           4        6       +2     
  Lines          80      149      +69     
==========================================
+ Hits           76      135      +59     
- Misses          2        7       +5     
- Partials        2        7       +5     
Impacted Files Coverage Δ
...lugins/kubernetes/apiserver/availability/plugin.go 91.30% <ø> (ø)
plugins/kubernetes/apiserver/latency/plugin.go 93.54% <ø> (ø)
plugins/slok-go-http-metrics/latency/plugin.go 82.60% <82.60%> (ø)
...lugins/slok-go-http-metrics/availability/plugin.go 91.30% <91.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3486521...17491ce. Read the comment docs.

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok slok merged commit 67fe7f4 into main Jun 7, 2021
@slok slok deleted the slok/go-http-metrics branch June 7, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant