Add mock for unixtojd #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bailey-spencer
force-pushed
the
feature_unixtojd
branch
from
2553bf9
to
930f688
Compare
asprega
reviewed
Apr 13, 2022
composer.json
Outdated
| @@ -19,7 +19,8 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=7.4.0", | |||
| "ext-uopz": ">=6.1.1" | |||
| "ext-uopz": ">=6.1.1", | |||
| "ext-calendar": "*" | |||
There was a problem hiding this comment.
would it make sense to not require this and mock unixtojd only if function exists, or extension is loaded? This way we don't force everyone using this library to have this extension (even though it seems enabled by default in most use cases).
There was a problem hiding this comment.
@asprega yes, that sounds like a good idea. I've updated the PR
bailey-spencer
force-pushed
the
feature_unixtojd
branch
from
930f688
to
1cfdf5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.