Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BeamPageType ] Added slideRightTransition , slideLeftTransition , slideTopTransition #477

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

Shiba-Kar
Copy link
Contributor

Added More transitions

  1. slideRightTransition
  2. slideLeftTransition
  3. slideTopTransition

Copy link
Owner

@slovnicki slovnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Shiba-Kar 👋
Thanks for the PR! 💙

It would be great to add some tests for these transitions. We have tests for other transitions here:

group('Transitions', () {

@Shiba-Kar
Copy link
Contributor Author

Hey @Shiba-Kar 👋 Thanks for the PR! 💙

It would be great to add some tests for these transitions. We have tests for other transitions here:

group('Transitions', () {

Have written tests , have a look !!

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #477 (6b701a9) into master (e6d6596) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   96.12%   96.25%   +0.12%     
==========================================
  Files          13       13              
  Lines         800      827      +27     
==========================================
+ Hits          769      796      +27     
  Misses         31       31              
Impacted Files Coverage Δ
package/lib/src/beam_page.dart 98.11% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d6596...6b701a9. Read the comment docs.

Copy link
Owner

@slovnicki slovnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Shiba-Kar 💙

@slovnicki slovnicki merged commit e68bb7c into slovnicki:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants