fix wildcard pattern matching for paths with multiple levels #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @cgaisl 💙 I will review this over the weekend and try to see how and why it breaks the current tests. |
slovnicki
reviewed
Mar 29, 2022
| checkMatch('/home/*', '/home', false); | ||
| checkMatch('/home*', '/home/one', false); | ||
| checkMatch('*', '', false); | ||
| checkMatch('*', '/', false); |
There was a problem hiding this comment.
I think these should match, but I get into problems with other tests if I make them match.
I'll get back to it tomorrow and probably push some additional stuff into this PR.
You're right about the fix you provided, I just need to revisit how it affects other (maybe bad) tests.
|
Ok, I did some additional work and now it should be ready to merge. It's here now, I copied your title and secription: #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 84d582e introduced a bug where the wildcard operator ('*') would only match paths one level deep. For example '/home/*' would match '/home/single', but not 'home/multiple/levels'.