Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wildcard pattern matching for paths with multiple levels #502

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

slovnicki
Copy link
Owner

@slovnicki slovnicki commented Apr 7, 2022

Original PR: #494

The commit 84d582e introduced a bug where the wildcard operator (*) would only match paths one level deep. For example /home/* would match /home/single, but not home/multiple/levels.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #502 (99a07dc) into master (f19b689) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   96.74%   96.79%   +0.04%     
==========================================
  Files          13       13              
  Lines         861      874      +13     
==========================================
+ Hits          833      846      +13     
  Misses         28       28              
Impacted Files Coverage Δ
package/lib/src/beam_location.dart 96.59% <100.00%> (+0.22%) ⬆️
package/lib/src/beamer_delegate.dart 94.57% <100.00%> (+0.07%) ⬆️
package/lib/src/beamer.dart 92.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19b689...99a07dc. Read the comment docs.

@slovnicki slovnicki merged commit 37cde88 into master Apr 7, 2022
@slovnicki slovnicki deleted the cgaisl-fix-wildcard-pattern-matching branch April 7, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants