Make the segment the same color as the text #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: this is likely to conflict with my other pull-request (#28) but I thought it best to keep them separate. Let me know if/when you integrate the other one and I'll rebase this one on the new code. |
|
And the demo library("ggplot2")
library("ggrepel")
set.seed(1)
n <- 10
d <- data.frame(x=runif(n), lab=letters[1:n])
ggplot(d) + geom_text(aes(x=x, y=x, label=lab), color="red")
ggplot(d) + geom_text_repel(aes(x=x, y=x, label=lab), color="red")
ggplot(d) + geom_text(aes(x=x, y=x, label=lab, color=lab))
ggplot(d) + geom_text_repel(aes(x=x, y=x, label=lab, color=lab)) |
Instead of setting segment.color to a mid-level grey, make it a bit transparent and color it according to the color of the text. By default the text is black and the half-transparent segment therefore still appears grey. When the text itself is made transparent, the transparency of the text and of the segment are combined (multiplied). Another possibility would be to declare two new *mappable* aesthetics: segment.color and segment.alpha, and let the user do the mapping (i.e. geom_text_repel(color=x, segment.color=x)) which would allow to color the text and segment separately. But I find it quite cumbersome for a small gain in versatility.
|
I've rebased on master and squashed into one commit make it easier for you to merge if you wish. |
|
Thank you! I'll consider merging this pull request soon. |
slowkow
added a commit
that referenced
this pull request
Mar 15, 2016
Make the segment the same color as the text
|
Thanks again for the pull request! I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting segment.color to a mid-level grey, make it a bit
transparent and color it according to the color of the text. By default
the text is black and the half-transparent segment therefore still
appears grey.
When the text itself is made transparent, the transparency of the text
and of the segment are combined (multiplied).
Another possibility would be to declare two new mappable aesthetics:
segment.color and segment.alpha, and let the user do the mapping (i.e.
geom_text_repel(color=x, segment.color=x)) which would allow to color
the text and segment separately. But I find it quite cumbersome for a
small gain in versatility.