feat: npm builder updates #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
asraa,
ianlewis and
joshuagl
as code owners
ianlewis
approved these changes
Nov 7, 2022
Comment on lines
+235
to
+236
| name: "<TODO>" | ||
| path: "<TODO>" |
There was a problem hiding this comment.
Were you planning on setting these?
There was a problem hiding this comment.
not in this PR. The output of the builder can theoretically contain multiple artifacts, so I think we need to write code to process severals artifacts at once. For nodejs, I think it will always be a single artifact. But in general I'm trying to see what's needed to build a "generic workflow" that generalizes for any builder (nodejs, Java, goreleaser, container images, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: