Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a RNG Action #503

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

laurentsimon
Copy link
Collaborator

This is part of #500 in order to generate random names.
In a follow-up PR, I will use names as some-name-<random>

Copy link
Collaborator

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

The project needs a README with all the actions.

@laurentsimon
Copy link
Collaborator Author

Any feedback on the name of the Action. PRNG makes it sound like a cryptographic PNRG, but it's not intended to be used as such. I think I'll rename to RNG instead :)

@naveensrinivasan
Copy link
Collaborator

After thinking about this should probably be written in go. This is adding tech debt.

@ianlewis
Copy link
Member

After thinking about this should probably be written in go. This is adding tech debt.

Yeah, I'd like to reduce our use of inline shell scripts if we can too. Though it's pretty small so I could go either way.

I think installing Go compiler and compiling the program will add too much overhead to these kind of small actions. And we also really want to avoid having to do a checkout of the repository as part of the action as there are version skew and security implications.

If we want to write them in another language I think the best choice would probably be writing it in Javascript. It works similarly to the Dockerfile actions, but doesn't require building the image every time before running it.

.github/actions/rng/action.yml Outdated Show resolved Hide resolved
.github/actions/rng/action.yml Outdated Show resolved Hide resolved
.github/actions/rng/action.yml Outdated Show resolved Hide resolved
@laurentsimon laurentsimon changed the title feat: Add a PRNG Action feat: Add a RNG Action Jul 11, 2022
@laurentsimon
Copy link
Collaborator Author

After thinking about this should probably be written in go. This is adding tech debt.

Yeah, I'd like to reduce our use of inline shell scripts if we can too. Though it's pretty small so I could go either way.

I think installing Go compiler and compiling the program will add too much overhead to these kind of small actions. And we also really want to avoid having to do a checkout of the repository as part of the action as there are version skew and security implications.

If we want to write them in another language I think the best choice would probably be writing it in Javascript. It works similarly to the Dockerfile actions, but doesn't require building the image every time before running it.

I'm also leaning towards TS. On the other hand, the script is really small. I'm not even sure I'd call it "tech debt".

@laurentsimon laurentsimon enabled auto-merge (squash) July 11, 2022 17:39
@laurentsimon laurentsimon merged commit 02b4d71 into slsa-framework:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants