Port the sha256 shell to go code #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
The goal for this port from shell script to `go` was to reduce the amount of shell script. It is easier to refactor managed code compared to shell script. This has been discussed slsa-framework#398 Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/feat/port-sha256-go
branch
from
9adb64e
to
c61e1a9
Compare
| hash := sha256.Sum256(data) | ||
| log.Printf("computed sha: %s\n", hex.EncodeToString(hash[:])) | ||
|
|
||
| cmd := exec.Command("/usr/bin/env", "bash", "-c", |
There was a problem hiding this comment.
Note: this can be done via printf. Given the discussion in #503 (comment), we may want to use TS instead of Go.
|
Closing this PR since it's been agreed it will be written in TS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for this port from shell script to
gowas to reduce theamount of shell script.
It is easier to refactor managed code compared to shell script.
This has been discussed #398
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com