Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more tests for GCB verification #389

Merged
merged 7 commits into from
Dec 5, 2022
Merged

feat: add more tests for GCB verification #389

merged 7 commits into from
Dec 5, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Dec 5, 2022 •
edited
Loading

@lukehinds thanks for the #377 you filed last week. Even though it was not a bypass (verifySignature() would fail), I have made some changes:

  1. Removed the use of slices and replaced the return of the function with a more traditional error
  2. Added unit tests for decoding function
  3. Added more unit tests to VerifySignature()
  4. Added more CLI tests

@laurentsimon
update
da0d988 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
update
80c64da 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
update
a921f68 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
update
32bdcec 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
update
4fb046d 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon laurentsimon requested review from asraa and ianlewis and removed request for asraa December 5, 2022 18:18
@laurentsimon
update
43a4c2a 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon
update
5336bdb 
Signed-off-by: laurentsimon <laurentsimon@google.com>
@laurentsimon laurentsimon merged commit 4a6c5b1 into slsa-framework:main Dec 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

@ianlewis ianlewis Awaiting requested review from ianlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsimon @asraa