Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix character overlap in toc (between caret-down and title) #212

Merged

Conversation

BFallert
Copy link
Contributor

Copy link
Contributor

@beatrycze-volk beatrycze-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should css files not be rebuild?

@stweil
Copy link
Contributor

stweil commented Oct 17, 2022

Yes, they should be rebuilt. Maybe it would be even better to remove generated files like Resources/Public/Css/allStyles.css, Resources/Public/Css/webStyles.css, Resources/Public/Css/rte.css, Resources/Public/JavaScript/allScripts.js or Resources/Public/JavaScript/webScripts.js from git and add them to .gitignore.

@csidirop
Copy link
Contributor

But then they would have to be created manually

@stweil
Copy link
Contributor

stweil commented Oct 17, 2022

Right, developers who use code from git would be forced to build them. But the TYPO3 extension should of course include them and not require an additional build step.

@BFallert
Copy link
Contributor Author

Sorry I forgot to recreate the CSS file.
If generated CSS and JS files are not included, it is a problem for dependent projects where then always remember that the css and js files must be generated manually.

@BFallert
Copy link
Contributor Author

... Maybe it would be even better to remove generated files ...

In this case you would have to document the necessary development environment, I get an error with npm install with nodejs versions > 17.3.1 for example.

@sebastian-meyer sebastian-meyer merged commit 035f9b6 into slub:master Oct 18, 2022
@BFallert BFallert deleted the feature/fix-toc-character-overlap branch October 26, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants