-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve backend module output #60
Conversation
…out, using Bootstrap classes
…e more independent regarding the widget ViewHelper template and be more integrative using default backend components
…but it's not the last step BackendTemplateView should be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. The backend module needs truly some refactoring. It is more or less the same since the beginning with TYPO3 4.7 (?).
Currently, it looks like this in my test setup with a screen resolution of 1920x1080:
With your changes it looks like this:
To be honest: It looks a bit broken. The search/filter fields above and the result listing shouldn't have a different width in my opinion.
Good idea but not ready to merge, I would say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. The backend slub-event-backend.css
file is browser cached. The standard TYPO3 cache clear doesn't help here. That's always the trouble when changing styles of backend modules. I should remember that.
That's what it looks like now on my test setup with TYPO3 10.4.
So'll merge this.
Thank you again.
This pull request is about taking the backend modules closer to the TYPO3 defaults and contains one bugfix related to the FunctionBarViewHelper. No changes in the business logic were made.
The layout should be more responsive and some no longer used style definitions were deleted.
Just take a look at it. If everything is fine, merge it please, otherwise let's talk about it.