Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backend module output #60

Merged
merged 10 commits into from
Mar 16, 2021
Merged

Conversation

twaurisch
Copy link
Contributor

This pull request is about taking the backend modules closer to the TYPO3 defaults and contains one bugfix related to the FunctionBarViewHelper. No changes in the business logic were made.
The layout should be more responsive and some no longer used style definitions were deleted.

Just take a look at it. If everything is fine, merge it please, otherwise let's talk about it.

@albig albig self-requested a review March 15, 2021 23:02
Copy link

@albig albig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. The backend module needs truly some refactoring. It is more or less the same since the beginning with TYPO3 4.7 (?).

Currently, it looks like this in my test setup with a screen resolution of 1920x1080:

New TYPO3 site  TYPO3 CMS 10 4 12  (4)

With your changes it looks like this:

New TYPO3 site  TYPO3 CMS 10 4 12  (3)

To be honest: It looks a bit broken. The search/filter fields above and the result listing shouldn't have a different width in my opinion.

Good idea but not ready to merge, I would say.

@twaurisch
Copy link
Contributor Author

Please make shure the current stylesheet file was loaded, maybe it's needed to clear the cache to rebuild compressed ressources.

The result should look like this, old house, new paint. 😄
Bildschirmfoto 2021-03-16 um 07 23 43

@albig albig self-requested a review March 16, 2021 12:41
Copy link

@albig albig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The backend slub-event-backend.css file is browser cached. The standard TYPO3 cache clear doesn't help here. That's always the trouble when changing styles of backend modules. I should remember that.

That's what it looks like now on my test setup with TYPO3 10.4.

New TYPO3 site  TYPO3 CMS 10 4 12  (5)

So'll merge this.

Thank you again.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants