Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Michal for looking after the shebang.
I am getting further errors when running on ubuntu-12.04 (aka precise)
The reason is that the
file
command does not return the same text on ubuntu-10.10 (aka lucid)Here is the file:
On lucid64, the file command returns:
On precise64:
As a consequence; on lucid64, bosh-solo status's action_type is "binary"
where as on precise64, it is "ruby".
This explains the difference of treatment and why on lucid64 we did not see the shebang issue reported in pull 48.
The next problem is this block of code around line 188 https://github.com/sm/sm/blob/master/core/internal/shell/extensions/execution/functions#L188:
It is not executed on lucid64; on precise64, it is executed and looks for the files:
/opt/sm/core/sm/shell/ruby/core/functions.rb
/opt/sm/core/sm/shell/ruby/core/initialize.rb
Both of which do not exist.
For now I have added a guard to check if they exist and silently skip them if they don't.
After that
sm bosh-solo status
works fine on precise.Thanks again for your attention!