This repository has been archived by the owner on Jun 4, 2019. It is now read-only.
Issue 79: Add managed creation/deletion of ephemeral implementations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emeral implementations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to fix issue 79.
Previously the 'Check Realizability' and 'MATLAB codegen' would surreptitiously create empty component implementations which would corrupt the state of the Xtext model and lead to parsing and analysis errors.
This fix makes the creation and deletion of ephemeral implementations compliant with the model API, creating packages to contain them and managing deletion using the transactional editing domains.